JPRO-cleanup Move Concept specific controllers out of properties into concept#727
JPRO-cleanup Move Concept specific controllers out of properties into concept#727vollbrecht-work wants to merge 1 commit into
Conversation
This is a first step to more clearly represent the **current** hirachical structure. This will hopefully in the future make it simpler to actually create "shared" properties classes. This PR does not move out History / Hierarchy Controllers. Since they currently are not exclusivly used by the ConceptController, but also still part of kview.lidr.mvvm.view.properties.
carldea
left a comment
carldea
left a comment
There was a problem hiding this comment.
Nice work!
I approved but I noticed merge conflict. I will merge once things are resolved.
|
@vollbrecht-work can you resolve the merge conflicts? can you test create concept and summon a concept from the concept navigator to verify that everything is working? I pulled down the branch and got an exception when choosing create concept. |
|
There's much activity in these files :-). Let me know maybe we redo this PR when others are finished with these files. Up to you. Know what I mean? Other developers have updated many of these files. And this PR is becoming out of date. I think it might be easy to abandon this PR and recreate it. Let me know your thoughts. |
|
yeah after we are done with the more pressing work i will rebase this once more |
|
@vollbrecht-work could you rebase and resolve conflicts again. sorry. I think we should merge this come first thing monday if possible. |
|
I'm wondering if we should redo this PR, because it's out of date. @vollbrecht-work Let me know your thoughts. |
4 participants
This is a first step to more clearly represent the current hirachical structure.
This will hopefully in the future make it simpler to actually create "shared" properties classes.
This PR does not move out History / Hierarchy Controllers. Since they currently are not exclusivly used by the ConceptController, but also still part of kview.lidr.mvvm.view.properties.