fix: replace debug print() statements with logger.debug() in metric modules - #81
Conversation
… 3.x compatibility
|
the lint failure appears to be related to the deprecated Node.js 20 GitHub Actions ) rather than the code changes. the same warning appears across other PRs in the repo as well |
|
Hey @Balamuralikrishna123, thanks for the contribution, but the PR needs a cleanup before we can merge. The zarr reader changes ( One thing I'd encourage, make sure you're reading through the changes before submitting. It's easy to miss things like bundled unrelated code, and we want contributors who are comfortable owning their changes. So just a quick sanity check:
Answer those, clean up the branch, and we'll get this merged! |
|
@kaveenh, please have a look! |
hi @Aman-Cool , thanks for pointing that out , yeah i noticed the zarr files got bundled in by mistake, i will clean that up and push a fix shortly.
|
|
@Balamuralikrishna123, I noticed this bundling in #82 too...have a look. |
|
opened a clean version without the zarr changes in PR #83, please review that one instead. sorry for the mess. |
|
@Balamuralikrishna123 Thanks for your contributions! Please avoid creating multiple PRs for the same changes. Please update or close existing PRs so maintainers can manage the repository efficiently. |
hey @kaveenh understood, sorry for the confusion! PR #83 is the clean version with only the logging changes. |
hi, i was going through the codebase and noticed issue #71
about replacing print() statements with proper logging.
i went through all the metric modules and replaced the debug
print() calls with logger.debug() and added the logger
setup at the top of each file where it was missing.
files changed:
this fixes the issue and makes the debug output properly
controllable through python logging levels instead of
always printing to stdout.
also working on the zarr reader in PR feat: add Zarr file format support #76 and planning
to tackle the ROOT reader from issue Add root file reader #49 next.