[ENH] Customization feature to choose a directory for dumping of log files during runtime#270
Open
dutta-alankar wants to merge 11 commits into
Open
[ENH] Customization feature to choose a directory for dumping of log files during runtime#270dutta-alankar wants to merge 11 commits into
dutta-alankar wants to merge 11 commits into
Conversation
Contributor
Author
|
This has small changes in |
## [2.2.01] 2025-04-16 ### Changed - Fix a bug that led to instabilities in the RKL scheme with very small grid spacings (idefix-code#323) - Fix a bug that prevented Idefix from running with Sycl backend (required on Intel GPUs) (idefix-code#331) - Fix an error that led to incorrect electrical current regularisation around the polar axis in non-Ideal MHD (idefix-code#333) - Improve div(B) checks with a dimensionless implementation, avoiding too large divB errors in grids with large stretch factors (idefix-code#334) ### Added - Time-Implicit drag for multiple dust species, preventing small time steps for strongly coupled dust grains (idefix-code#321) - Collisionless heat flux added to the Braginskii module (idefix-code#317) - New global `idfx::DumpArray` debugging function to dump any Idefix array into a numpy array that can read from python (idefix-code#318) - Automatic benchmark plots in the documentation (idefix-code#319) - More CI tests of grid coarsening (idefix-code#329) - Dump outputs based on wallclock time (idefix-code#335) --------- Co-authored-by: Victor Réville <victorreville@gmail.com> Co-authored-by: Hal Bal <vreville@irap.omp.eu> Co-authored-by: Jean Kempf <jean.kempf@irap.omp.eu> Co-authored-by: Victor Réville <47865059+vreville@users.noreply.github.com> Co-authored-by: Marc Coiffier <marc.coiffier@univ-grenoble-alpes.fr> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
## [2.2.02] 2025-10-18 ### Changed - Added a module to add explicit units (idefix-code#338) - fixed a bug that could lead to incorrect profiling information on non-blocking cuda loops (idefix-code#341) - fixed a bug that could lead to incorrect energy budget when shearing box and fargo were both enabled (idefix-code#346) - fixed a bug that led to incorrect BX2 reconstruction when axis is not used on both sides of the domain (idefix-code#345) - fixed a bug that led to incorrect reflective boundary conditions on B when DIMENSIONS < 3 (idefix-code#345) - fixed a bug that led to incorrect dust stopping time when the adiabatic equation of state is used with "size" drag law (idefix-code#353) ### Added - documentation for the continuous integration (idefix-code#354) --------- Co-authored-by: Victor Réville <victorreville@gmail.com> Co-authored-by: Hal Bal <vreville@irap.omp.eu> Co-authored-by: Jean Kempf <jean.kempf@irap.omp.eu> Co-authored-by: Victor Réville <47865059+vreville@users.noreply.github.com>
… with zizmor + pre-commit (idefix-code#373) * SEC: switch GHA refs to immutable hashes with pinact * SEC: disable default gha permissions * SEC: avoid leaking credentials * SEC: enable security audits with zizmor + pre-commit
### Changed - fixed a bug that could lead to diverging results around the spherical axis in non-ideal MHD in 2.5D and 3D (idefix-code#356) - refactor of the MPI exchange routines and boundary routines to avoid buildup of roundoff errors at domain faces/edges that could lead to the sudden burst of div(B) or incoherences between MPI sub-domains (idefix-code#357) - fixed a bug that could lead to compilations error when targetting AMD APUs (idefix-code#359) - fixed a bug that led to the generation of incorrect subviews in 2.5D with vector_potential enabled (idefix-code#362) - fixed a bug that could lead to memory corruption when using the UCT_HLLD emf reconstruction scheme and DIMENSIONS < COMPONENTS (idefix-code#363) - reorganise the test to separate specific IO tests from physics tests (idefix-code#367) ### Added - magnetic vector potential is now accessible from pydefix when enabled (idefix-code#361) - use ccache in the test suite to reduce the runtime of continuous integration (idefix-code#364) - automatically detects pybind11 path with cmake when using pydefix (idefix-code#367) - skeleton to run the test suite with pytest (idefix-code#366) --------------------------------------------------------------------------- Co-authored-by: Clément Robert <cr52@protonmail.com> Co-authored-by: Sébastien Valat <sebastien.valat.dev@orange.fr>
glesur
requested changes
Apr 22, 2026
glesur
left a comment
Contributor
There was a problem hiding this comment.
thanks for this contribution, and apologies for the delay in getting back to you.
| std::stringstream sslogFileName; | ||
| sslogFileName << "idefix." << idfx::prank << ".log"; | ||
|
|
||
| sslogFileName << idfx::logFileDir << "/./" << "idefix." << idfx::prank << ".log"; |
Contributor
There was a problem hiding this comment.
Suggested change
| sslogFileName << idfx::logFileDir << "/./" << "idefix." << idfx::prank << ".log"; | |
| sslogFileName << idfx::logFileDir << "/" << "idefix." << idfx::prank << ".log"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customization feature to choose a directory for dumping of log files
Often having a custom directory for dumping of log files is very useful to have the code files and executable separated from the location of data dumps. In this PR, this can be achieved by specifying log_dir in the Output block of idefix.ini. I remember that PLUTO already has such an option and it was quite helpful to me, personally as it prevented me to from accidentally overwriting the log files. I hope the developers find this a useful feature to have.
I tested with the KHI HD problem. Also sharing the relevant
.inifile and the cmake command used is:cmake $IDEFIX_DIR/ -DIdefix_MPI=ON -DIdefix_HDF5=ON -DCMAKE_CXX_FLAGS="-DXDMF_DOUBLE"Contents of
idefix.ini