Scope: minimize the number of gets#41
Merged
Merged
Conversation
If getting the scope prefix value is a miss, then we all keys under the scope are by definition a miss, so we don't need to bother looking. This defers the generating and storing of the scope prefix value till we actually need it (on a set). In practice, this will reduce the number of gets if using getMultiple() or if you don't always *set()* on a miss.
danielbeardsley
force-pushed
the
scope--minimize-storing
branch
from
66bfe5f to
0621920
Compare
masonmcelvain
previously approved these changes
Dec 23, 2025
masonmcelvain
left a comment
masonmcelvain
left a comment
There was a problem hiding this comment.
CR 👏🏻 but dev_block 👍🏻 on what might be a bug
The Short circuit should prevent getMultiple from being called and we weren't explicitly check for that.
We weren't using the $scopeValue we just created when doing the set(). Also, refactor it for clarity. Add a test to ensure we're setting the value.
masonmcelvain
previously approved these changes
Dec 24, 2025
masonmcelvain
left a comment
masonmcelvain
left a comment
There was a problem hiding this comment.
CR 👏🏻 Looks much better, thanks!
Member
|
un_dev_block 👍 Looks like this is ready to test again. |
Member
|
@danielbeardsley Does this need testing, or is it ready to merge? |
so phpunit stops complaining
Member
Author
|
It passes tests. So, I guess QA 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If getting the scope prefix value is a miss, then we all keys under the scope are by definition a miss, so we don't need to bother looking.
This defers the generating and storing of the scope prefix value till we actually need it (on a set). In practice, this will reduce the number of gets if using getMultiple() or if you don't always set() on a miss.