Make View & Modal's default impl of on_error() use logging.error() instead of print(file=sys.stderr) - #264
Open
anamoyee wants to merge 2 commits into
Open
Conversation
…of print(file=sys.stderr)
anamoyee
changed the title
View & Modal's default on_error() callbacks use logging.error() instead of print(file=sys.stderr)View & Modal's default impl of on_error() use logging.error() instead of print(file=sys.stderr)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows for logging the "Ignoring exception in view" errors + compatibility with logging customizers (e.g.
rich.loggingor a manual impl of a handler), which formats tracebacks in a different way than python's default. Before this change the way to do it would be to subclassmiru.Viewand import & remember to use that subclass across the project. I think this change makes for a nicer default.Example (upper half some other error, lower half miru's error):
With this change:
