-
Notifications
You must be signed in to change notification settings - Fork 12
Add row link to show all repeat posts #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dashaluna
wants to merge
8
commits into
master
Choose a base branch
from
add-row-link-to-show-all-repeat-posts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
dc3633a
Add row link to Repeating posts - to show all its Repeat posts
dashaluna 39ee079
Merge branch 'post-status-links-for-repeatable-posts' into add-row-li…
dashaluna 96422ce
Improve logic for is_repeating_post function, make sure to test that …
dashaluna 7e4fbff
Only highlight view link when all results are displayed, remove it if…
dashaluna 35e75cb
Add query to count the Repeat Posts for the row link. Display the cor…
dashaluna 25c03f0
Use _n for singular and plural text display in row links depending on…
dashaluna e89d539
Merge branch 'master' into add-row-link-to-show-all-repeat-posts
dashaluna e79f33a
Improve count of Repeat posts for row action links. Run one query str…
dashaluna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@willmot is there a better approach to store the count of repeat posts to make it quicker? Maybe a maintained meta data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I'd be tempted to just skip showing the number in that list, I'm not sure it's worth the complexity. Especially as you'll see the count one you click the link.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I've chatted to @johnbillion and he suggested to run a query with all parents IDs that currently on the page, that sounds like a good solution - I'm working on it atm.
When you click to see a specific post's Repeat posts, the overall number in the view link does not change! It shows count for all Repeating and Repeat posts overall. This is similar to core WP, when you click a specific author (not yourself) the view link looses the bold focus, but the count stays the same. Hope that makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good point, and nice idea!