Fix max_steps=0 being silently ignored in run() - #2542
Open
meddadaek wants to merge 1 commit into
Open
Conversation
|
Bumping this for visibility — it's a 1-line real bug: Tests pass. The fix is minimal — changed Also have 4 companion test PRs adding test coverage for existing issues (#2541, #2543, #2544, #2545) — all mergeable, zero conflicts. Happy to rebase any of them if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2458
max_steps = max_steps or self.max_stepstreatsmax_steps=0asfalsy, so passing max_steps=0 silently falls back to the agent's
default instead of actually running zero steps. Changed to an
explicit None check so 0 is respected.