Convert to ESM: use .mjs everywhere - #30
Merged
Merged
Conversation
- Rename test.js → test.mjs with ESM import syntax - Rename snapshot.cjs → snapshot.mjs with ESM import syntax - Add "type": "module" to package.json - Update npm-publish.yml require() calls for ESM compatibility
… colors - Download and vendor snapshot-rev4.json from hsluv/hsluv main branch - Rewrite snapshot.mjs to read colors from vendored JSON and compute SCSS snapshot values via Sass compilation - Generate _snapshot.scss with all 4096 colors (up from 16) - Add .prettierignore for generated snapshot file - Fix SassNumber unit detection (deg) for proper SCSS output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test.js→test.mjswith ESMimportsyntaxsnapshot.cjs→snapshot.mjswith ESMimportsyntax"type": "module"topackage.jsonnpm-publish.ymlto use ESM-compatible JSON imports instead ofrequire()snapshot-rev4.jsonfrom hsluv/hsluv as test data sourcesnapshot.mjsto read from vendored JSON and generate_snapshot.scssvia Sass compilation across all 4096 reference colors (up from 16).prettierignorefor the generated_snapshot.scssfiledegunit serializationAll 57,370 tests pass and lint is clean.