Make modifications so it works with latest json0 presence PR#1
Open
curran wants to merge 2 commits into
Open
Conversation
Author
|
Updated to function with ottypes/json0#31 (Quill and textarea, haven't updated the check boxes). |
curran
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@houshuang So, I've spend a whole day with this, and I want to say thank you for putting this together! It's a bit messy with the custom packages, but still I was able to use this to learn more about presence and ultimately make some substantive progress.
This PR contains modifications to make this work (at least the Quill part) with the latest work from ottypes/json0#31 .