fix: use a custom helper for path traversal tests#377
Open
BlankParticle wants to merge 1 commit into
Open
Conversation
BlankParticle
force-pushed
the
fix/path-traversal-tests
branch
from
fb6dcdb to
3d5a0e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test that were testing path traversal using
supertestwere not testing the proper behaviour.supertestusessuperagentunder the hood which automatically normalizes the path and there is no way to turn this behaviour off. This means hono was receiving normalized/secret.txtinstead of/static/../secret.txtsuperagentis full of some of these footguns, like in #368superagentsuddenly started doing brotli decompression in the major version without anyway to opt out, but it doesn't do zst compression. Now the test suite fixtures are testing against are 2 different types, one real brotli fixture and one fake zst fixture.https://e18e.dev is trying to get the ecosystem to migrate away from superagent e18e/ecosystem-issues#257, so probably migrating away from
supertestalso makes senseThis PR introduces a small
requestServerutil that has similar interface tofetchbuilt on node:http, this interface can replace like 90% ofsupertestusage in here, for the remaining we will need to add some specialized functions for things like testing HTTP/2 and TLS.I am only replacing the affected path tests in this PR and introducing this new helper to the codebase as a cataleyist for the future migration