feat: detect nub package manager - #124
Open
colinhacks wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates create-hono’s package-manager detection so that when the tool is invoked via nub, it recognizes the npm_config_user_agent prefix (nub/<version>) and defaults dependency installation commands accordingly.
Changes:
- Extend the
PackageManagerunion type to includenub. - Add
nub installto the known package manager command map. - Detect
nubfromnpm_config_user_agentingetCurrentPackageManager().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| type PackageManager = 'npm' | 'bun' | 'deno' | 'pnpm' | 'yarn' | ||
| type PackageManager = 'npm' | 'bun' | 'deno' | 'pnpm' | 'yarn' | 'nub' | ||
|
|
||
| const knownPackageManagers: { [key: string]: string } = { |
Comment on lines
+151
to
+153
| if (agent.startsWith('nub')) { | ||
| return 'nub' | ||
| } |
Author
|
CI is green on this one — happy to make changes if needed, otherwise flagging it for a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When invoked through nub, create-hono defaults to npm. It reads the invoking package manager from
npm_config_user_agentingetCurrentPackageManagerand falls back to npm; nub advertisesnub/<version>, so it isn't matched.nub is a Rust CLI with a pnpm-compatible command grammar. This adds
nubto thePackageManagertype, theknownPackageManagersmap (nub install), and the user-agent detection.