Skip to content

fix: handling spawn hang - #115

Merged
yusukebe merged 1 commit into
honojs:mainfrom
ryuapp-contrib:fix/spawn-timeout
Dec 2, 2025
Merged

fix: handling spawn hang#115
yusukebe merged 1 commit into
honojs:mainfrom
ryuapp-contrib:fix/spawn-timeout

Conversation

@ryuapp

@ryuapp ryuapp commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

closes #113

Run the package manager and set a timeout in case it hangs for any reason. For example, #113 .
I set the time to 3 seconds, but I don't have a strong opinion on the time.

@yusukebe yusukebe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe

yusukebe commented Dec 2, 2025

Copy link
Copy Markdown
Member

@ryuapp

Looks good. I think 3 seconds is ok. Thank you!

@yusukebe
yusukebe merged commit 037ccb7 into honojs:main Dec 2, 2025
3 checks passed
@ryuapp
ryuapp deleted the fix/spawn-timeout branch December 2, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failure in Package Manager Installation Check

2 participants