Skip to content

fix(build): call context.dispose() after first app is successfully built #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yusukebe merged 1 commit into from
Jan 10, 2026
Merged

fix(build): call context.dispose() after first app is successfully built #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/utils/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,15 @@ export async function* buildAndImportApp(
})

await context.watch()
if (!options.watch) {
await context.dispose()
}

do {
yield await appPromise!
const app = await appPromise!
if (!options.watch) {
// `context.dispose()` must be called after first build result to avoid race condition
// https://github.com/honojs/cli/issues/66
await context.dispose()
}
yield app
preparePromise()
} while (options.watch)
}