Skip to content

Add devcontainer-lock.json file#171982

Merged
edenhaus merged 2 commits into
devfrom
Add-devcontainer-lock.json-file
May 24, 2026
Merged

Add devcontainer-lock.json file#171982
edenhaus merged 2 commits into
devfrom
Add-devcontainer-lock.json-file

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented May 23, 2026

Proposed change

I had to rebuild my devcontainer today. It seems that with one of the recent updates to VSCode, they have now started to generate this file on builds, as this will impact all new and rebuilds. It should be committed to the codebase with the current values it generates.
I have verified that the sha it generated matches what has been published to ghcr for the feature referenced.

An alternative to this approach is to add this file to .gitignore.

The change was done here devcontainers/cli#1212

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

@ludeeus ludeeus requested a review from edenhaus as a code owner May 23, 2026 18:15
Copilot AI review requested due to automatic review settings May 23, 2026 18:15
@ludeeus ludeeus requested a review from a team as a code owner May 23, 2026 18:15
@home-assistant home-assistant Bot added cla-signed small-pr PRs with less than 30 lines. labels May 23, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a .devcontainer/devcontainer-lock.json file to pin the resolved Dev Container feature digest, keeping Dev Container rebuilds consistent as newer VS Code/Dev Containers tooling begins generating this lock file.

Changes:

  • Add .devcontainer/devcontainer-lock.json locking ghcr.io/devcontainers/features/github-cli:1 to a specific published SHA256 digest.
  • Record integrity metadata for the locked feature to ensure reproducible builds.

@ludeeus ludeeus added the bugfix label May 24, 2026
@edenhaus edenhaus merged commit 3016198 into dev May 24, 2026
48 checks passed
@edenhaus edenhaus deleted the Add-devcontainer-lock.json-file branch May 24, 2026 08:38
@github-actions github-actions Bot locked and limited conversation to collaborators May 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix cla-signed small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Commit .devcontainer/devcontainer-lock.json to the repository

5 participants