fix(basemgr): trailing newline in FreeSWITCH Backgrounding stderr check#212
Open
brancan wants to merge 1 commit intohnimminh:masterfrom
Open
fix(basemgr): trailing newline in FreeSWITCH Backgrounding stderr check#212brancan wants to merge 1 commit intohnimminh:masterfrom
brancan wants to merge 1 commit intohnimminh:masterfrom
Conversation
FreeSWITCH stderr ends with 'Backgrounding.\n', not 'Backgrounding.', so the old endswith check always failed and logged a false ERROR on every normal startup.
brancan
added a commit
to brancan/libresbc-fork
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
fsinstance()inbasemgr.pychecks FreeSWITCH stderr to detect a successful background start:FreeSWITCH actually outputs
Backgrounding.\n(with a trailing newline). The old check always evaluates toTrueon a normal startup, so every successful FreeSWITCH launch logs a false ERROR and setsresult = False.Fix
One character change — matches the actual FreeSWITCH output.
Notes
This bug was also independently identified in PR #179. This PR isolates the fix as a standalone, minimal change with no other modifications.