Skip to content

chore: override toString methods in records - #26817

Merged
andrewb1269 merged 3 commits into
hiero-ledger:mainfrom
Grigorov-Georgi:chore/add-to-string-methods-to-key-pair-records
Aug 17, 2026
Merged

chore: override toString methods in records#26817
andrewb1269 merged 3 commits into
hiero-ledger:mainfrom
Grigorov-Georgi:chore/add-to-string-methods-to-key-pair-records

Conversation

@Grigorov-Georgi

Copy link
Copy Markdown
Contributor

Description:

Override the default toString() in SchnorrKeyPair and TssKeyPair records to output only its public key.

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Georgi Grigorov <georgi.grigorov@limechain.tech>
@Grigorov-Georgi Grigorov-Georgi self-assigned this Aug 13, 2026
@lfdt-bot

lfdt-bot commented Aug 13, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@Grigorov-Georgi
Grigorov-Georgi marked this pull request as ready for review August 13, 2026 02:52
@Grigorov-Georgi
Grigorov-Georgi requested a review from a team as a code owner August 13, 2026 02:52
@Grigorov-Georgi Grigorov-Georgi changed the title chore: override toString methods to records chore: override toString methods in records Aug 13, 2026
@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #26817      +/-   ##
============================================
- Coverage     70.50%   70.50%   -0.01%     
  Complexity    11691    11691              
============================================
  Files          2587     2587              
  Lines        108453   108456       +3     
  Branches      12142    12141       -1     
============================================
- Hits          76469    76464       -5     
- Misses        27994    28005      +11     
+ Partials       3990     3987       -3     
Files with missing lines Coverage Δ Complexity Δ
...a/node/app/history/impl/ProofKeysAccessorImpl.java 95.12% <100.00%> (+0.12%) 0.00 <0.00> (ø)
...main/java/com/hedera/node/app/tss/TssKeyFiles.java 76.99% <100.00%> (+0.20%) 0.00 <0.00> (ø)
.../main/java/com/hedera/node/app/tss/TssKeyPair.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)

... and 9 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Georgi Grigorov <georgi.grigorov@limechain.tech>

@joshmarinacci joshmarinacci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the failling hapi test. Probably a flak.

@testlens-app

testlens-app Bot commented Aug 17, 2026

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: 4f06cee
▶️ Tests: 52542 executed
⚪️ Checks: 33/33 completed


Learn more about TestLens at testlens.app.

@andrewb1269

Copy link
Copy Markdown
Contributor

All checks pass on #26860 so merging this PR.

@andrewb1269
andrewb1269 merged commit 861ca79 into hiero-ledger:main Aug 17, 2026
38 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants