chore: override toString methods in records - #26817
Merged
andrewb1269 merged 3 commits intoAug 17, 2026
Merged
Conversation
Signed-off-by: Georgi Grigorov <georgi.grigorov@limechain.tech>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Grigorov-Georgi
marked this pull request as ready for review
August 13, 2026 02:52
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #26817 +/- ##
============================================
- Coverage 70.50% 70.50% -0.01%
Complexity 11691 11691
============================================
Files 2587 2587
Lines 108453 108456 +3
Branches 12142 12141 -1
============================================
- Hits 76469 76464 -5
- Misses 27994 28005 +11
+ Partials 3990 3987 -3
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: Georgi Grigorov <georgi.grigorov@limechain.tech>
joshmarinacci
approved these changes
Aug 14, 2026
joshmarinacci
left a comment
Contributor
There was a problem hiding this comment.
please check the failling hapi test. Probably a flak.
✅ All tests passed ✅🏷️ Commit: 4f06cee Learn more about TestLens at testlens.app. |
petreze
approved these changes
Aug 17, 2026
ibankov
approved these changes
Aug 17, 2026
Contributor
|
All checks pass on #26860 so merging this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Override the default
toString()inSchnorrKeyPairandTssKeyPairrecords to output only its public key.Notes for reviewer:
Checklist