feat: switch block stream and TSS configs defaults for the cutover process - #26107
feat: switch block stream and TSS configs defaults for the cutover process#26107petreze wants to merge 109 commits into
Conversation
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #26107 +/- ##
============================================
- Coverage 70.50% 70.31% -0.20%
+ Complexity 11691 11686 -5
============================================
Files 2587 2587
Lines 108453 108454 +1
Branches 12142 12141 -1
============================================
- Hits 76469 76260 -209
- Misses 27994 28206 +212
+ Partials 3990 3988 -2
... and 35 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
…n-suite-with-77-configs
|
We likely want to hold off merging this now with the revert |
petreze
left a comment
There was a problem hiding this comment.
Yep, I moved it to draft and put a big sign DO NOT MERGE at the top, just in case 😆
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
# Conflicts: # hedera-node/test-clients/build.gradle.kts
28 file(s) changed in commit be66219
be66219 to
b2b21a4
Compare
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
b2b21a4 to
6efe492
Compare
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
750567e to
121ef61
Compare
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
# Conflicts: # hedera-node/test-clients/build.gradle.kts
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
2 file(s) changed in commit 77eae10
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
# Conflicts: # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/staking/StakingSuite.java
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
🚨 TestLens detected 2007 failed tests 🚨Here is what you can do:
Test Summary600: [FLOW] PR Checks / MATS / HAPI Tests / HAPI Tests (Atomic Batch) > :test-clients:testSubprocessConcurrent (first 40 of 708)
600: [FLOW] PR Checks / MATS / HAPI Tests / HAPI Tests (Misc Records, Crypto & Misc Serial) > :test-clients:testSubprocess (first 40 of 45)
600: [FLOW] PR Checks / MATS / HAPI Tests / HAPI Tests (Misc Records, Crypto & Misc Serial) > :test-clients:testSubprocessConcurrent (first 40 of 289)
600: [FLOW] PR Checks / MATS / HAPI Tests / HAPI Tests (Misc) > :test-clients:testSubprocessConcurrent
600: [FLOW] PR Checks / MATS / HAPI Tests / HAPI Tests (Simple Fees & ND Reconnect) > :test-clients:testSubprocess (first 40 of 60)
600: [FLOW] PR Checks / MATS / HAPI Tests / HAPI Tests (Simple Fees & ND Reconnect) > :test-clients:testSubprocessConcurrent (first 40 of 613)
600: [FLOW] PR Checks / MATS / HAPI Tests / HAPI Tests (Smart Contracts & ISS) > :test-clients:testSubprocessConcurrent (first 40 of 293)
600: [FLOW] PR Checks / MATS / HAPI Tests / HAPI Tests (State Throttling) > :test-clients:testSubprocess
600: [FLOW] PR Checks / MATS / HAPI Tests / HAPI Tests (Token, Time Consuming & Node Staking) > :test-clients:testSubprocess
600: [FLOW] PR Checks / MATS / HAPI Tests / HAPI Tests (Token, Time Consuming & Node Staking) > :test-clients:testSubprocessConcurrent
🏷️ Commit: 62b8196 Test Failures (first 10 of 2059)AtomicAutoAccountCreationSuite > autoAccountCreationBadAlias() > as written (:test-clients:testSubprocessConcurrent in 600: [FLOW] PR Checks / MATS / HAPI Tests / HAPI Tests (Atomic Batch))AtomicAutoAccountCreationSuite > autoCreateWithNftFallBackFeeFails() > as written (:test-clients:testSubprocessConcurrent in 600: [FLOW] PR Checks / MATS / HAPI Tests / HAPI Tests (Atomic Batch))AtomicAutoAccountCreationSuite > canAutoCreateWithFungibleTokenTransfersToAlias() > as written (:test-clients:testSubprocessConcurrent in 600: [FLOW] PR Checks / MATS / HAPI Tests / HAPI Tests (Atomic Batch))AtomicAutoAccountCreationSuite > canAutoCreateWithHbarAndTokenTransfers() > as written (:test-clients:testSubprocessConcurrent in 600: [FLOW] PR Checks / MATS / HAPI Tests / HAPI Tests (Atomic Batch))AtomicAutoAccountCreationSuite > canAutoCreateWithNftTransferToEvmAddress() > as written (:test-clients:testSubprocessConcurrent in 600: [FLOW] PR Checks / MATS / HAPI Tests / HAPI Tests (Atomic Batch))AtomicAutoAccountCreationSuite > canAutoCreateWithNftTransfersToAlias() > as written (:test-clients:testSubprocessConcurrent in 600: [FLOW] PR Checks / MATS / HAPI Tests / HAPI Tests (Atomic Batch))AtomicAutoAccountCreationSuite > canGetBalanceAndInfoViaAlias() > as written (:test-clients:testSubprocessConcurrent in 600: [FLOW] PR Checks / MATS / HAPI Tests / HAPI Tests (Atomic Batch))AtomicAutoAccountCreationSuite > cannotAutoCreateWithTxnToLongZero() > as written (:test-clients:testSubprocessConcurrent in 600: [FLOW] PR Checks / MATS / HAPI Tests / HAPI Tests (Atomic Batch))AtomicAutoAccountCreationSuite > failureAfterHollowAccountCreationReclaimsAlias() > as written (:test-clients:testSubprocessConcurrent in 600: [FLOW] PR Checks / MATS / HAPI Tests / HAPI Tests (Atomic Batch))AtomicAutoAccountCreationSuite > hollowAccountCreationWithCryptoTransfer() > as written (:test-clients:testSubprocessConcurrent in 600: [FLOW] PR Checks / MATS / HAPI Tests / HAPI Tests (Atomic Batch))Muted Tests (first 20 of 2055)Note Checks are currently running using the configuration below. Select tests to mute in this pull request: 🔲 AccessListTest > accessListDiscountTest() Reuse successful test results: 🔲 ♻️ Only rerun the tests that failed or were muted before Click the checkbox to trigger a rerun: 🔲 Rerun jobs Learn more about TestLens at testlens.app. |
Summary
Final step of the block-stream cutover (#25892): flip the production defaults so the consensus node produces blocks, signs them with real TSS signatures, and streams them over gRPC to a Block Node by default — retiring the legacy record stream and the dual file/gRPC write.
Production changes
Config defaults (
hedera-config):blockStream.streamModeBOTHBLOCKSblockStream.writerModeFILE_AND_GRPCGRPCblockStream.enableCutoverfalsetrueblockStream.streamWrappedRecordBlockstruefalseblockStream.buffer.isBufferPersistenceEnabledfalsetruetss.forceMockSignaturestruefalseBlockRecordService: supporting adjustment for sourcing block/running-hash info inBLOCKSmode.configuration/dev: aligned to the new defaults (BLOCKS; WRAPS proving-key download disabled).Test harness & CI
writerMode/streamMode(the new default), not just explicit overrides (SharedNetworkLauncherSessionListener) — so every subprocess HAPI job that implies streaming gets a live (DinD) Block Node.BlockSource/BlockNodeBlockSource/FileSystemBlockSource/BlockSourceFactory) +StreamValidationOpread blocks back from the Block Node and run the data-independent validators inBLOCKSmode; freeze-block-aware gating and "settle before replay" for the gRPC read-back.writerMode=FILE(no in-process Docker; backpressure stays off while still exercising trueBLOCKSsemantics with a file sink).805-call-execute-hapi-tests.yaml,build.gradle.kts); transition scaffolding removed.BLOCKS/gRPC test fixes:ContractCreateTranslatorhex guard, deterministic sidecar extraction (SidecarWatcher), block-stream assertions, genesis/subprocess suites.Related issue(s):
Fixes #25892
Notes for reviewer:
Checklist