Skip to content

css: pin footer to bottom of screen #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Andersama wants to merge 3 commits into
base: master
Choose a base branch
from
Open

css: pin footer to bottom of screen #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3941540
Update style.styl
Andersama Jan 17, 2021
b0ed36e
Update _variables.styl
Andersama Jan 17, 2021
095831e
Update footer.styl
Andersama Jan 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions source/css/_partial/footer.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#footer
background: color-footer-background
padding: 50px 0
padding: footer-padding 0
border-top: 1px solid color-border
color: color-grey
a
Expand All @@ -11,4 +11,4 @@

#footer-info
line-height: line-height
font-size: 0.85em
font-size: 0.85em
6 changes: 5 additions & 1 deletion source/css/_variables.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ article-padding = 20px
mobile-nav-width = 280px
main-column = 9
sidebar-column = 3
// Footer
footer-padding = 50px
// Total size of footer
footer-height = 2*footer-padding + 38.33px

if sidebar and sidebar isnt bottom
_sidebar-column = sidebar-column
Expand All @@ -60,4 +64,4 @@ columns = main-column + _sidebar-column
// Media queries
mq-mobile = "screen and (max-width: 479px)"
mq-tablet = "screen and (min-width: 480px) and (max-width: 767px)"
mq-normal = "screen and (min-width: 768px)"
mq-normal = "screen and (min-width: 768px)"
6 changes: 5 additions & 1 deletion source/css/style.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,4 +87,8 @@ if sidebar is left
@import "_partial/mobile"

if sidebar
@import "_partial/sidebar"
@import "_partial/sidebar"

// pin the footer to the bottom of the screen even if content is small
body > div#container > div#wrap > div.outer
min-height: s('calc(100vh - %s - %s)',banner-height, footer-height)