Allow empty notification when using "AcquireNotify"#1983
Open
dlech wants to merge 2 commits intohbldh:developfrom
Open
Allow empty notification when using "AcquireNotify"#1983dlech wants to merge 2 commits intohbldh:developfrom
dlech wants to merge 2 commits intohbldh:developfrom
Conversation
Add parametrization to test start_notify() with both use_start_notify True and False on Linux. These have significantly different code paths.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1983 +/- ##
===========================================
+ Coverage 52.06% 52.45% +0.38%
===========================================
Files 43 43
Lines 4091 4097 +6
Branches 503 504 +1
===========================================
+ Hits 2130 2149 +19
+ Misses 1830 1817 -13
Partials 131 131
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull request overview
This PR aims to allow valid zero-length payloads to pass through the BlueZ AcquireNotify path instead of being treated as an error, addressing issue #1982 in the Linux backend.
Changes:
- Removed the explicit empty-read check in the BlueZ notification fd reader.
- Expanded integration notification/indication tests to exercise both
StartNotifyandAcquireNotifypaths on BlueZ. - Added an integration test for empty notification payload delivery and documented the fix in the changelog.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
bleak/backends/bluezdbus/client.py |
Adjusts AcquireNotify fd read handling for empty payloads. |
tests/integration/test_client_characteristics.py |
Broadens notification test coverage and adds an empty-payload notification test. |
CHANGELOG.rst |
Documents the BlueZ empty-notification fix under Unreleased. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dlech
force-pushed
the
bluez-empty-notification
branch
4 times, most recently
from
b140a54 to
9a64167
Compare
…reNotify Drop the check for empty data in the AcquireNotify callback. Normally in Python, read() returning an empty bytes object indicates EOF. In this case, it just means that a notification with an empty payload was received, which is perfectly valid. Fixes: hbldh#1982
dlech
force-pushed
the
bluez-empty-notification
branch
from
9a64167 to
bdbbf89
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the check for empty data in the "AcquireNotify" callback. Normally in Python,
read()returning an empty bytes object indicates EOF. In this case, it just means that a notification with an empty payload was received, which is perfectly valid.Fixes: #1982