ci: a failing pyright run now also lets the CI job fail on windows.#1971
Merged
Conversation
On windows a PowerShell is used instead of a bash. On a PowerShell only the last exit code is checked, so if pyright fails and mypy passes the CI is not failing.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1971 +/- ##
========================================
Coverage 51.24% 51.24%
========================================
Files 39 39
Lines 3934 3934
Branches 486 486
========================================
Hits 2016 2016
Misses 1791 1791
Partials 127 127
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On windows a PowerShell is used instead of a bash. On a PowerShell only the last exit code is checked, so if pyright fails and mypy passes the CI is not failing.
I noticed this while working on #1944.