Skip to content

tests: Update bumble to v0.0.226#1959

Merged
dlech merged 1 commit intohbldh:developfrom
timrid:update-bumble-to-v0.0.226
Mar 28, 2026
Merged

tests: Update bumble to v0.0.226#1959
dlech merged 1 commit intohbldh:developfrom
timrid:update-bumble-to-v0.0.226

Conversation

@timrid
Copy link
Copy Markdown
Contributor

@timrid timrid commented Mar 25, 2026

This updates bumble to v0.0.226. This is mainly necessary for my work on the new Android backend and I need these changes in bumble.

After the update I tried the integration tests with macOS and Windows locally without problems. Linux is tested via the CI.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.24%. Comparing base (b2670ab) to head (996cedd).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1959   +/-   ##
========================================
  Coverage    51.24%   51.24%           
========================================
  Files           39       39           
  Lines         3934     3934           
  Branches       486      486           
========================================
  Hits          2016     2016           
  Misses        1791     1791           
  Partials       127      127           
Flag Coverage Δ
bluez-integration-py3.10 38.40% <ø> (ø)
bluez-integration-py3.11 38.40% <ø> (ø)
bluez-integration-py3.12 38.40% <ø> (ø)
bluez-integration-py3.13 38.40% <ø> (ø)
bluez-integration-py3.14 36.83% <ø> (ø)
macos-latest-py3.10 19.87% <ø> (ø)
macos-latest-py3.11 19.87% <ø> (ø)
macos-latest-py3.12 19.87% <ø> (ø)
macos-latest-py3.13 19.87% <ø> (ø)
macos-latest-py3.14 19.69% <ø> (ø)
ubuntu-latest-py3.10 23.86% <ø> (ø)
ubuntu-latest-py3.11 23.86% <ø> (ø)
ubuntu-latest-py3.12 23.86% <ø> (ø)
ubuntu-latest-py3.13 23.86% <ø> (ø)
ubuntu-latest-py3.14 21.91% <ø> (ø)
windows-latest-py3.10 18.45% <ø> (ø)
windows-latest-py3.11 18.45% <ø> (ø)
windows-latest-py3.12 18.45% <ø> (ø)
windows-latest-py3.13 18.45% <ø> (ø)
windows-latest-py3.14 18.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlech
Copy link
Copy Markdown
Collaborator

dlech commented Mar 26, 2026

Can we also drop the type ignore comments on notify_subscribers() calls? I fixed that in Bumble a while back, so hopefully type hints should be correct now.

@timrid
Copy link
Copy Markdown
Contributor Author

timrid commented Mar 27, 2026

Can we also drop the type ignore comments on notify_subscribers() calls? I fixed that in Bumble a while back, so hopefully type hints should be correct now.

Unfortunately, no. The stubs are still incomplete because only Attribute is specified. I guess correct would be Attribute[Any].

image

@dlech dlech merged commit c9fa119 into hbldh:develop Mar 28, 2026
41 of 43 checks passed
@dlech
Copy link
Copy Markdown
Collaborator

dlech commented Mar 28, 2026

Thanks!

@timrid timrid deleted the update-bumble-to-v0.0.226 branch March 30, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants