Skip to content

add new permissions from android API 31#1642

Open
tomaszduda23 wants to merge 1 commit intohbldh:developfrom
tomaszduda23:develop
Open

add new permissions from android API 31#1642
tomaszduda23 wants to merge 1 commit intohbldh:developfrom
tomaszduda23:develop

Conversation

@tomaszduda23
Copy link
Copy Markdown

Pull Request Guidelines for Bleak

Before you submit a pull request, check that it meets these guidelines:

  1. If the pull request adds functionality, the docs should be updated.
  2. Modify the CHANGELOG.rst, describing your changes as is specified by the
    guidelines in that document.
  3. The pull request should work for Python 3.8+ on the following platforms:
    • Windows 10, version 16299 (Fall Creators Update) and greater
    • Linux distributions with BlueZ >= 5.43
    • OS X / macOS >= 10.11
  4. Squash all your commits on your PR branch, if the commits are not solving
    different problems and you are committing them in the same PR. In that case,
    consider making several PRs instead.
  5. Feel free to add your name as a contributor to the AUTHORS.rst file!

@dlech
Copy link
Copy Markdown
Collaborator

dlech commented Oct 2, 2024

We've been discussing this in #1621.

My preference would be to move this to a separate function in addition to adding the require permissions for newer Android versions.

@tomaszduda23
Copy link
Copy Markdown
Author

We've been discussing this in #1621.

My preference would be to move this to a separate function in addition to adding the require permissions for newer Android versions.

done

Comment thread bleak/backends/p4android/scanner.py Outdated
Comment thread bleak/backends/scanner.py Outdated
Comment thread examples/kivy/main.py Outdated
Comment thread examples/kivy/main.py Outdated
Comment thread bleak/backends/p4android/scanner.py Outdated
@dlech
Copy link
Copy Markdown
Collaborator

dlech commented Oct 5, 2024

Also, we will need a changelog entry explaining that this is a breaking change.

@tomaszduda23
Copy link
Copy Markdown
Author

updated according to review notes

@tomaszduda23 tomaszduda23 force-pushed the develop branch 2 times, most recently from f72cd38 to 1d556f1 Compare October 17, 2024 19:56
@tomaszduda23
Copy link
Copy Markdown
Author

tomaszduda23 commented Oct 17, 2024

github action should have started itself after pushing new version. It takes way to much time to fix all lint.

@dlech
Copy link
Copy Markdown
Collaborator

dlech commented Oct 17, 2024

Don't worry about the linting, I can fix it when I get back to this.

@tomaszduda23
Copy link
Copy Markdown
Author

any chance to get it merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants