Fix empty ID assertion, simplify equality check#10330
Open
zbynek wants to merge 3 commits into
Open
Conversation
niloc132
reviewed
Jun 8, 2026
| ViewData vd = (ViewData) o; | ||
| return equalsOrBothNull(original, vd.original) | ||
| && equalsOrBothNull(text, vd.text) && isEditing == vd.isEditing | ||
| return Objects.equals(original, vd.original) |
Member
There was a problem hiding this comment.
alternatively, use pattern match instanceof in the return here, something like
Suggested change
| return Objects.equals(original, vd.original) | |
| return o instanceof ViewData vd | |
| && Objects.equals(original, vd.original) |
Collaborator
Author
There was a problem hiding this comment.
Do we want to start using Java 17 features?
Co-authored-by: Colin Alworth <colin@vertispan.com>
zbynek
added
the
ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two issues found by nullness analysis:
Idis created from an element, theidattribute is never null and the empty string check was skipped. WhenIdis created from a string (never happens in GWT itself) and the string happens to benull, the assertion would result in NPE rather than assertion error.Objects.equalswhich had an unusednullcheck (I assume the API didn't exist in JDK back when this wasimplemented, but can be used now).