Skip to content

improve auth capabilities for notification client and Swagger UI#304

Merged
mgoetzegb merged 2 commits intomainfrom
ARTOSI-192-service-account-preparation
Apr 17, 2026
Merged

improve auth capabilities for notification client and Swagger UI#304
mgoetzegb merged 2 commits intomainfrom
ARTOSI-192-service-account-preparation

Conversation

@mgoetzegb
Copy link
Copy Markdown
Member

@mgoetzegb mgoetzegb commented Apr 15, 2026

What

  • add: notifications - Allow authentication via Client Credentials flow (breaking change)

  • change: make swagger docs compatible with access/authorization code flow

Why

We need to authenticate with client credentials in some scenarions.

Also Implicit auth flow is deprecated and should not be used. So we need the Swagger UI with access/authorization code flow.

References

ARTOSI-258

Checklist

  • Tests

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA acb8264.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@mgoetzegb mgoetzegb added the minor release Set label to create a minor release label Apr 15, 2026
@github-actions
Copy link
Copy Markdown

Conventional Commits Report

Type Number
Changed 1
Added 1

🚀 Conventional commits found.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 28.00000% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.59%. Comparing base (d0bd8a1) to head (acb8264).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/notifications/mocks/AuthClient.go 0.00% 41 Missing ⚠️
pkg/swagger/ginSwagger.go 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
- Coverage   57.13%   56.59%   -0.55%     
==========================================
  Files          70       71       +1     
  Lines        3945     4006      +61     
==========================================
+ Hits         2254     2267      +13     
- Misses       1493     1543      +50     
+ Partials      198      196       -2     
Flag Coverage Δ
opensearch-tests 95.68% <ø> (ø)
postgres-tests 92.03% <ø> (ø)
unit-tests 51.19% <28.00%> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mgoetzegb mgoetzegb marked this pull request as ready for review April 16, 2026 12:25
@mgoetzegb mgoetzegb requested review from a team as code owners April 16, 2026 12:25
@mgoetzegb mgoetzegb force-pushed the ARTOSI-192-service-account-preparation branch from 0a7a16d to 9fa0a76 Compare April 16, 2026 18:17
Comment thread pkg/auth/auth_client.go Outdated
Comment thread pkg/auth/auth_client.go Outdated
Comment thread pkg/auth/auth_client.go
Comment thread pkg/auth/auth_client.go
@efernasier
Copy link
Copy Markdown

I'm not sure why govulncheck is failing. It seems doesn't like the way we are using testcontainers.

Maybe we may need a further ticket to move testcontainers usage out of the main library build.

Should we create a maintenance ticket?

@mgoetzegb
Copy link
Copy Markdown
Member Author

I'm not sure why govulncheck is failing. It seems doesn't like the way we are using testcontainers.

Maybe we may need a further ticket to move testcontainers usage out of the main library build.

Should we create a maintenance ticket?

There is already a PR: #305 ;)

Note: It is not yet compatible with authorization code + PKCE. If that becomes necessary see open PR of related package: swaggo/echo-swagger#100
@mgoetzegb mgoetzegb force-pushed the ARTOSI-192-service-account-preparation branch from 4cd26de to acb8264 Compare April 17, 2026 11:12
@mgoetzegb mgoetzegb enabled auto-merge April 17, 2026 11:13
@mgoetzegb mgoetzegb merged commit 0b60fe1 into main Apr 17, 2026
11 of 12 checks passed
@mgoetzegb mgoetzegb deleted the ARTOSI-192-service-account-preparation branch April 17, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor release Set label to create a minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants