Add: missing notification Level urgent#295
Merged
alex-heine merged 2 commits intomainfrom Mar 4, 2026
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Conventional Commits Report
🚀 Conventional commits found. |
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #295 +/- ##
=======================================
Coverage 57.29% 57.29%
=======================================
Files 70 70
Lines 3939 3939
=======================================
Hits 2257 2257
Misses 1486 1486
Partials 196 196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mgoetzegb
approved these changes
Mar 4, 2026
alex-heine
added a commit
to greenbone/opensight-notification-service
that referenced
this pull request
Mar 6, 2026
## What - Add ruleoptions endpoint - Change all Level references to notificaitons.Level ## Why To ensure no wrong level's are saved and the ruleoptions return everything needed to create a notification rule. ## References - greenbone/opensight-golang-libraries#295 - https://jira.greenbone.net/browse/VTI-784 ## Checklist - [ ] Tests - [ ] Got all spots for the Rule.Level type string replaced by notifications.Level
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
To cover all possible notification Levels
References
Checklist