Skip to content

add: httpassert - support http method consts from stdlib in Perform#289

Merged
mgoetzegb merged 1 commit intomainfrom
http-assert-perform
Feb 17, 2026
Merged

add: httpassert - support http method consts from stdlib in Perform#289
mgoetzegb merged 1 commit intomainfrom
http-assert-perform

Conversation

@mgoetzegb
Copy link
Copy Markdown
Member

@mgoetzegb mgoetzegb commented Feb 16, 2026

What

add: httpassert - support http method consts from stdlib in Perform

Why

When using Perform it is common to use as verb value the constants defined in the go std lib http package. Unlike the current implementation, the verbs/methods are all uppercase there. So support that additionally for added convenience.

Checklist

  • Tests

@mgoetzegb mgoetzegb requested a review from a team as a code owner February 16, 2026 14:11
@mgoetzegb mgoetzegb added the minor release Set label to create a minor release label Feb 16, 2026
@mgoetzegb mgoetzegb requested a review from a team as a code owner February 16, 2026 14:11
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 16, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 457d64f.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@github-actions
Copy link
Copy Markdown

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 16, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.34%. Comparing base (da805ea) to head (457d64f).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/httpassert/request.go 83.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #289   +/-   ##
=======================================
  Coverage   57.34%   57.34%           
=======================================
  Files          69       69           
  Lines        3887     3887           
=======================================
  Hits         2229     2229           
  Misses       1470     1470           
  Partials      188      188           
Flag Coverage Δ
opensearch-tests 95.66% <ø> (ø)
postgres-tests 91.96% <ø> (ø)
unit-tests 51.91% <83.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

When using `Perform` it is common to use as verb value the constants defined in the go std lib `http` package. Unlike the current implementation the verbs are all uppercase there. So support that additionally for added convenience.
@mgoetzegb mgoetzegb enabled auto-merge (squash) February 17, 2026 10:33
@mgoetzegb mgoetzegb merged commit 29f0395 into main Feb 17, 2026
13 checks passed
@mgoetzegb mgoetzegb deleted the http-assert-perform branch February 17, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor release Set label to create a minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants