fix: notifications - cache token to avoid auth failure on repeated calls#273
Merged
fix: notifications - cache token to avoid auth failure on repeated calls#273
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Conventional Commits Report
🚀 Conventional commits found. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
==========================================
+ Coverage 57.36% 57.66% +0.29%
==========================================
Files 68 69 +1
Lines 3781 3812 +31
==========================================
+ Hits 2169 2198 +29
- Misses 1432 1433 +1
- Partials 180 181 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alex-heine
reviewed
Dec 16, 2025
mgoetzegb
commented
Dec 16, 2025
Member
Author
mgoetzegb
left a comment
mgoetzegb
left a comment
There was a problem hiding this comment.
Addressed all comments.
alex-heine
previously approved these changes
Dec 16, 2025
stefanTolksdorf
requested changes
Dec 18, 2025
stefanTolksdorf
previously approved these changes
Dec 18, 2025
stefanTolksdorf
approved these changes
Dec 18, 2025
Previously we were retrieving the acess token from Keycloak for each request to the notification service. This is not efficient and furthermore keycloak deactivates the user temporarily when it detects an excessing amount of logins. Moved the authentication to a separate client as it can be useful on its own in other scenarios. This is a breaking change in the notification client initialization.
mgoetzegb
force-pushed
the
VTI-775-fix-notification-client
branch
from
9e44526 to
dba7b37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
fix: notifications - cache token to avoid auth failure on repeated calls
Why
Previously we were retrieving the acess token from Keycloak for each request to the notification service.
This is not efficient and furthermore keycloak deactivates the user temporarily when it detects an excessing amount of logins.
Moved the authentication to a separate client as it can be useful on its own in other scenarios. This is a breaking change in the notification client initialization.
References
VTI-775
Checklist