Skip to content

VTA-635: Add OpenSearch MustNotExists to querybuilder #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-heine merged 3 commits into from
Nov 13, 2025
Merged

VTA-635: Add OpenSearch MustNotExists to querybuilder #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49a3a91
Add: OpenSearch Query MustNotExists to querybuilder
alex-heine Nov 13, 2025
8a4fc22
change: remove HandleCompareOperatorMustNotExists and use negation of…
alex-heine Nov 13, 2025
6a1cfbc
Change: Rename DSL query naming mustNotExists to doesNotExist
alex-heine Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/openSearch/osquery/boolQueryBuilder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ func (q *BoolQueryBuilder) AddFilterRequest(request *filter.Request) error {
if handler, ok := operatorMapping[field.Operator]; ok {
value := field.Value

if field.Operator == filter.CompareOperatorExists {
if field.Operator == filter.CompareOperatorExists || field.Operator == filter.CompareOperatorDoesNotExist {
value = "" // exists operator does not need a value, but for more consistent handling just pass a dummy value
}
if value == nil {
Expand Down Expand Up @@ -289,5 +289,9 @@ func defaultCompareOperators() []CompareOperator {
Operator: filter.CompareOperatorExists,
Handler: HandleCompareOperatorExists, MustCondition: true,
},
{
Operator: filter.CompareOperatorDoesNotExist,
Handler: HandleCompareOperatorExists, MustCondition: false,
},
}
}
9 changes: 9 additions & 0 deletions pkg/openSearch/osquery/boolQueryBuilder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,6 +608,15 @@ func TestBoolQueryBuilder_AddFilterRequest(t *testing.T) {
wantDocuments: []ostesting.TestType{doc0, doc1, doc2},
})

// MustNotExists operator
addTest("operator must not Exists", testCase{
filterRequest: singleFilter(filter.RequestField{
Name: "keywordOmitEmptyField",
Operator: filter.CompareOperatorDoesNotExist,
}),
wantDocuments: []ostesting.TestType{doc0},
})

// BetweenDates operator
addTest("operator BetweenDates (date time string)", testCase{
filterRequest: singleFilter(filter.RequestField{
Expand Down
1 change: 1 addition & 0 deletions pkg/query/filter/type.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ CompareOperator ENUM(
betweenDates

exists
doesNotExist

isEqualToRating
isNotEqualToRating
Expand Down
4 changes: 4 additions & 0 deletions pkg/query/filter/type_enum.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading