feat: log signer validation outcomes with payer context#989
Closed
MoonBoi9001 wants to merge 1 commit into
Closed
Conversation
Distinguish between "no escrow accounts found for payer" (likely subgraph lag) and "signer not in authorized list" (genuine mismatch). Previously both cases returned the same generic error with no logging. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1c50cd9 to
c14d30d
Compare
9a12fb3 to
46a2659
Compare
Contributor
Coverage Report for CI Build 25478616228Warning No base build found for commit Coverage: 71.35%Details
Uncovered Changes
Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
Member
Author
|
Superseded by #1009 — the signer-validation module this PR adds logging to is removed wholesale in the on-chain offer-based authorization switch, so the logging additions become dead code. Dropping in favour of the architecture change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
When the indexer rejects a paid indexing proposal because the proposer's signing key isn't authorized, the rejection reaches the consumer but the indexer writes nothing to its own logs. This change adds structured logs at warn or debug for each signer-validation outcome. Operators can now tell a transient indexing lag apart from a real authorization mismatch.
Motivation
When a paid indexing proposal arrives, the indexer looks up the proposer's escrow account in a subgraph and checks whether the signing key is on the authorized list for that payer. If either step fails the proposal is rejected, but with no log line and the same generic outcome on the wire. The two failure modes are very different in operational terms: an escrow account that simply hasn't been indexed yet is a transient subgraph lag the operator can wait out, while a signer genuinely missing from the authorized list is a real authorization problem. Operators triaging a wave of rejections cannot tell these apart and waste time chasing the wrong root cause.
Summary