refactor: remove dead DIPs cancel and collect endpoints#1036
Open
MoonBoi9001 wants to merge 2 commits into
Open
refactor: remove dead DIPs cancel and collect endpoints#1036MoonBoi9001 wants to merge 2 commits into
MoonBoi9001 wants to merge 2 commits into
Conversation
CancelAgreement was a no-op on the indexer side: the handler returned Unimplemented because cancellation now lives on-chain in the RecurringCollector contract. Dipper retried the dead-letter every 20s forever. Also rename signed_voucher to signed_rca to match the bytes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CollectPayment was the off-chain voucher-era collection RPC: indexers submitted a signed work claim and dipper returned a TAP micropayment receipt. On-chain RCA collects directly via SubgraphService.collect(), so this RPC is dead. gateway.proto and its bindings can also go. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
MoonBoi9001
force-pushed
the
mb9/remove-legacy-cancel-grpc
branch
from
3f684aa to
cd456bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
The DIPs gRPC surface had two endpoints that returned Unimplemented because cancellation and collection now happen on-chain. Delete them, the gateway proto that only carried collection, and the misleading
signed_voucherfield name. Pure dead-code cleanup with no behaviour change.Motivation
The DIPs gRPC surface defines endpoints that dipper calls into the indexer with. Two of them — CancelAgreement and CollectPayment — held over from the off-chain voucher design before DIPs moved on-chain. With RCA in place, the RecurringCollector contract is the source of truth for cancellations and the SubgraphService contract handles collections directly, so both handlers were stubs that returned "not implemented" to every call.
Dipper treats those errors as transient and retries each one every twenty seconds in a loop that never converges, polluting logs and creating ongoing maintenance footprint. While the proto compatibility break is already happening, this also renames
signed_vouchertosigned_rcaon the proposal request: the bytes have been an ABI-encoded SignedRCA for a while and only the field label still called it a voucher.Summary
Stacked on PR #1009. cargo build, cargo clippy with CI flags, and cargo test all pass on indexer-dips and indexer-service-rs.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com