Update Argos thermometer to read set point - #959
Closed
brg7910 wants to merge 2 commits into
Closed
Conversation
|
|
|
Author
|
Closing in favour of supporting multiple temperature channels from the Argos, please see #969 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Argos thermometer device to read set point
It would be great to figure out how to track all the data; boiler temp, gh temp, boiler target, set point but we will need to decide how to do so; possible a custom Argo preparation method/device?
We would also need to decide how all these values should appear in Visualizer as the current API only seems to support temp target, temp mix and basket temp.