Visualise Bloom/pre-infusion and first drip time - #1132
Open
icnagy wants to merge 5 commits into
Open
Conversation
- Add getEventMarkerShapes() to GraphHelperService with bar-line and background-region modes, colour-aware for dark/light mode - Bake markers into Plotly.newPlot layout for detail and card views; update via relayout only on value-change events in the live view - Add optional brew input to GraphDisplayCardComponent for card markers - Add settings toggle, mode selector, and colour pickers to settings page - Add EN i18n strings for all new settings labels - 13 new tests covering all shape-builder scenarios
…hDisplayCard - settings-event-markers.spec.ts: plain class tests covering constructor defaults and initializeByObject backward-compat migration guards for brew_event_markers_enabled, brew_event_markers_mode, bloomMarker and firstDripMarker graph color entries (9 tests) - brew-brewing-graph-event-markers.spec.ts: TestBed unit tests for updateEventMarkers() — early-exit guards, stale shape filtering, non-marker shape preservation, idempotent update, and Plotly.relayout call verification (8 tests) - graph-display-card-event-markers.spec.ts: TestBed tests for initializeFlowChart() verifying getEventMarkerShapes is called only when brew is set, marker shapes/annotations are included in the Plotly.newPlot layout, and exactly one newPlot call per invocation (4 tests) All 34 event-marker tests (including existing GraphHelperService specs) pass in Docker (ChromeHeadlessNoSandbox). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
|
icnagy
marked this pull request as ready for review
July 28, 2026 19:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visualise Bloom/pre-infusion and first drip time