fix: return reflect.Value from Field.resolve to preserve Go interface - #764
Merged
pavelnikolov merged 4 commits intoJul 2, 2026
Merged
Conversation
When a resolver method returns a Go interface and the concrete type has extra exported methods, method indices computed at schema-build time don't match at runtime because reflect.ValueOf(any) unwraps to the concrete type. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… type (graph-gophers#763) Field.resolve() returned any, which erases the Go interface type via result.Interface(). When the concrete type has extra methods, method indices computed against the interface at build time don't match the concrete type at runtime, causing a reflect panic. Returning reflect.Value instead avoids the type-erasing round-trip. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Rename test fixtures to include issue number (issue763ThingResolver, issue763ConcreteThingResolver) matching established convention - Add comment on AaExtra explaining why it exists and why its name matters - Use RunTest (singular) instead of RunTests for single test case Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pavelnikolov
previously approved these changes
Jul 2, 2026
Signed-off-by: Pavel Nikolov <me@pavelnikolov.net>
pavelnikolov
force-pushed
the
fix/issue-763-interface-method-index
branch
from
July 2, 2026 05:56
407cf10 to
4505fc3
Compare
Member
|
fixes: #763 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
reflect: Call using X as type Ypanic when Go interface resolver has concrete type with extra methods #763Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com