feat(s3): add S3Storage adapter#220
Conversation
- currently only works for deno - is based on the jsr package `@bradenmacdonald/s3-lite-client@0.7.4`, which is not available on npm
|
Thanks for contribution. You can unignore But i'm not sure what to do with |
|
I will see what I can find regarding the issues with jsr and pnpm workspaces. Would it make sense to set the package manager version in package.json, so it can simply be installed using |
yea i guess it need to be updated to pnpm 9 version, i'll add changes to main branch. Thanks for pointing it. |
- add JSR registry to `.npmrc` - using `workspace:*` as version specifier to stop pnpm complaining about private workspace packages https://pnpm.io/workspaces#referencing-workspace-packages-through-aliases https://jsr.io/docs/npm-compatibility
and apply deno fmt
and sort them alphabetically
This comment has been minimized.
This comment has been minimized.
and remove vendored type S3StorageClient
|
@Satont I was able to resolve all todos in the code and I think I also managed to cater for all your comments. If there is anything else required for the PR to land, let me know. |
|
Is there an ETA for landing/reviewing this PR, or is there anything I can do to support that it happens? |
|
Hello. Is this still alive? I can write adapter myself, if not. |
@bradenmacdonald/s3-lite-client@0.7.5, which is not available on npm.npmrcworkspace:*as version specifier to stop pnpm complaining about private workspace packages after adding the JSR registryhttps://pnpm.io/workspaces#referencing-workspace-packages-through-aliases
https://jsr.io/docs/npm-compatibility