Skip to content

Add alert group state actions - #44

Open
Genmin wants to merge 1 commit into
grafana:mainfrom
Genmin:codex/add-alert-group-state-actions
Open

Add alert group state actions#44
Genmin wants to merge 1 commit into
grafana:mainfrom
Genmin:codex/add-alert-group-state-actions

Conversation

@Genmin

@Genmin Genmin commented May 1, 2026

Copy link
Copy Markdown

Summary

  • add AlertGroupService methods for acknowledge, unacknowledge, resolve, and unresolve
  • route each method to the documented Grafana OnCall alert group action endpoint
  • cover all state-action endpoints, including escaped alert group IDs

Validation

  • /opt/homebrew/bin/go test ./... -run '^Test(AlertGroupStateActions|GetAlertGroup|GetAlertGroupWithSpecialCharacters)$'\n- git diff --check\n\nNote: a full /opt/homebrew/bin/go test ./... run still fails in pre-existing integration fixture comparisons around dynamic_labels in integration_test.go; the alert group tests pass.

@Genmin
Genmin requested a review from a team as a code owner May 1, 2026 06:32
@Genmin
Genmin requested review from roberthorn and the-it and removed request for a team May 1, 2026 06:32
@cla-assistant

cla-assistant Bot commented May 1, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@cla-assistant

cla-assistant Bot commented May 1, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@the-it the-it left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking good. We need a CLA signing from you tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants