Expose RetryClient externally - #18
Open
erplsf wants to merge 1 commit into
Open
Conversation
erplsf
marked this pull request as ready for review
May 9, 2024 07:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greetings,
This is a bit far-reaching PR. We're using https://github.com/grafana/terraform-provider-grafana which uses this library for Grafana OnCall API.
terraform-provider-grafanahas an option calledinsecure_skip_verifywhich allows to use the provider when hosting Grafana on self-signed (/self-hosted) certificates.insecure_skip_verifyoption that is defined, used inparseTLSConfigmethod which is used only once for configuring main Grafana API client, which in turns mean that we cannot use the provider to connect to Grafana OnCall API with self-signed certificates.As
terraform-provider-grafanauses this library, the easy way to change that is to exposeRetryableHTTPclient field publicly, so users of this library (terraform-provider-grafana) can use the sameparseTLSConfigand pass the appropriate TLS settings to underlying Go HTTP Client.PR for
terraform-provider-grafanawill come after this change is merged. Here are the proposed changes (plus the dependency file changes for updating ref to this library) forterraform-provider-grafana: grafana/terraform-provider-grafana@main...klar-mx:terraform-provider-grafana:pr/upstream-changes