-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Report why the Node SSR server failed, and serve without SSR on the expected port #13681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+160
−12
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
bbb35db
Bundle postcss into the SSR build so ssr_mode works in installed builds
abidlabs 9761543
Serve without SSR on the user-facing port when Node can't start
abidlabs 167aced
Detect require calls precisely, and don't overlap the two servers
abidlabs 7020aa0
Report the degraded URL from local_url so it can't print 0.0.0.0
abidlabs 3baedae
Narrow local_url before the membership check to satisfy the typechecker
abidlabs 5f85954
Merge main; drop the frontend fix now that #13673 landed
abidlabs c913481
add changeset
gradio-pr-bot 4ea89dc
changes
abidlabs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@self/app": patch | ||
| "gradio": patch | ||
| --- | ||
|
|
||
| fix:Fix SSR mode failing on every render (`Cannot find module 'postcss'`) in installed builds, and serve without SSR on the expected port when the Node server can't start | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving this as-is: no space after
fix:is this repo's existing convention — most changesets onmainare written that way (fix:Preserve original filenames...,fix:Reset audio playback position...,feat:workflow: add model endpoint integration), and.changeset/changeset.cjsstrips the prefix when generating the changelog, so the space doesn't affect the output.Applied the other suggestion — the warning now uses
self.local_urlso it can't print0.0.0.0.