fix: restore shared prop forwarding across components - #13680
Closed
dawoodkhan82 wants to merge 1 commit into
Closed
fix: restore shared prop forwarding across components#13680dawoodkhan82 wants to merge 1 commit into
dawoodkhan82 wants to merge 1 commit into
Conversation
Collaborator
🪼 branch checks and previews
Install Gradio from this PR pip install https://huggingface.co/buckets/gradio/pypi-previews/resolve/986430ee9e1b61ea427bc83abe224d6fa22719af/gradio-6.20.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@986430ee9e1b61ea427bc83abe224d6fa22719af#subdirectory=client/python"Import Gradio JS Client from this PR via CDN import { Client } from "https://huggingface.co/buckets/gradio/npm-previews/resolve/986430ee9e1b61ea427bc83abe224d6fa22719af/browser.js"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #13644 and #13623. This restores shared props that stopped reaching their component implementations after frontend prop partitioning:
panelandcompactvariants applyroot, HTMLpadding, JSON/Plottheme_mode, Tabscale, and Textbox validation-error behaviortheme_modeinto the shared app config for all consumerspaddingcontract to booleanThis PR is temporarily stacked on recovery PR #13679. After #13679 restores the pre-push
maintree, this PR should be retargeted tomain.Related: #13623
AI Disclosure
🎯 PRs Should Target Issues
This is the reviewed follow-up for #13623 after #13644 was accidentally marked merged by a misdirected direct push.
Testing and Formatting Your Code
CI=1 pnpm exec vitest run --config .config/vitest.config.ts js/column/Column.test.ts js/dataset/Dataset.test.ts js/html/HTML.test.ts js/json/JSON.test.ts js/plot/Plot.test.ts js/tabitem/TabItem.test.ts js/textbox/Textbox.test.ts— 158 passed, 7 todopnpm exec playwright test js/spa/test/shared_props.spec.ts --config=.config/playwright.config.js— 1 passedpnpm build— passedpnpm ts:checkstill reports 16 unrelated baseline/environment errors; the shared HTML padding diagnostic from this change was resolved.