Skip to content

chore: update bigtable cloud monitoring exporter test CI for Java 8 #13621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lqiu96 merged 4 commits into from
Jul 1, 2026
Merged

chore: update bigtable cloud monitoring exporter test CI for Java 8 #13621

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0ebb980
chore: use withoutAnnotations() when mocking MetricServiceStub in mon…
nnicolee Jul 1, 2026
ad6db7f
Merge branch 'main' into test-bigtablecloud
nnicolee Jul 1, 2026
c77718e
style: use Mockito.withSettings() in test
nnicolee Jul 1, 2026
c4018d7
Merge branch 'test-bigtablecloud' of github.com:googleapis/google-clo…
nnicolee Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...gle/cloud/bigtable/data/v2/internal/csm/exporter/BigtableCloudMonitoringExporterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@
import org.junit.Rule;
import org.junit.Test;
import org.mockito.ArgumentCaptor;
import org.mockito.Mock;
import org.mockito.junit.MockitoJUnit;
import org.mockito.junit.MockitoRule;

Expand All @@ -81,7 +80,7 @@ public class BigtableCloudMonitoringExporterTest {

@Rule public final MockitoRule mockitoRule = MockitoJUnit.rule();

@Mock private MetricServiceStub mockMetricServiceStub;
private MetricServiceStub mockMetricServiceStub;
private MetricServiceClient fakeMetricServiceClient;
private BigtableCloudMonitoringExporter exporter;

Expand All @@ -107,6 +106,8 @@ public class BigtableCloudMonitoringExporterTest {

@Before
public void setUp() {
mockMetricServiceStub =
mock(MetricServiceStub.class, org.mockito.Mockito.withSettings().withoutAnnotations());

@lqiu96 lqiu96 Jul 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we avoid the fully qualified name?

Mockito.withSettings()...

@nnicolee nnicolee Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, will update!

fakeMetricServiceClient = new FakeMetricServiceClient(mockMetricServiceStub);

exporter =
Expand Down
Loading