reload4j: fix broken build - #15886
Open
xingyaner wants to merge 1 commit into
Open
Conversation
|
xingyaner is a new contributor to projects/reload4j. The PR must be approved by known contributors before it can be merged. The past contributors are: henryrneh, fmeum, aschaich |
xingyaner
force-pushed
the
fix-reload4j
branch
from
August 11, 2026 09:00
4a3253d to
afac1c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reload4j build fails because NewAsyncAppender.java imports the JDK-internal class sun.rmi.runtime.Log, while the java.rmi module does not export the sun.rmi.runtime package to application code. Upstream commit 70dba2d205f17cedc9ccd555877ffe13b2909216 added this import, although it has not been counterfactually verified as the root-cause commit. Since the imported type is unused, remove the import before compiling reload4j to resolve the module-access error without changing NewAsyncAppender behavior.