extend lattigo.chebyshev with domain start/end#3000
Open
AlexanderViand wants to merge 1 commit into
Open
Conversation
Collaborator
|
This looks good to me. Add a test and we can merge it. |
AlexanderViand
force-pushed
the
lattigo-add-chebyshev-domain-start-end
branch
from
4ccb671 to
9cc9605
Compare
Collaborator
Author
Done + some small cleanup (now an optional size-2 dense array instead of two required float attrs) |
j2kun
approved these changes
May 29, 2026
j2kun
added
the
pull_ready
Collaborator
|
Due to a change that updated a copybara behavior (3a41d2f), I will need you to rebase over main, sorry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While it's usually a good idea to massage your model/application into a shape where it only requires approximations over the default [-1,1], sometimes you do need a different interval and HEIR wasn't exposing the options from the Lattigo API in the IR.