Add support for pooling_ncw_sum#2995
Open
mdgrs wants to merge 1 commit into
Open
Conversation
j2kun
approved these changes
May 27, 2026
Collaborator
j2kun
left a comment
j2kun
left a comment
There was a problem hiding this comment.
Looks great! Please squash the commits and we'll get it in
mdgrs
force-pushed
the
mdgrs/avgPool1DTris
branch
from
2c5c841 to
1af5dde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I play the same trick as in the 2D convolution case and rewrite the pooling operation as a convolution.
While trying to lower a small convolutional network, I also came across some dimensionality mismatch (expand/collapse dims). I have included fixes in this PR, as well as tests.