Skip to content

Fix panic on malformed OSPF packets #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mohammadmseet-hue wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −0
Open

Fix panic on malformed OSPF packets #1229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions layers/ospf.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,9 @@ func getLSAsv2(num uint32, data []byte) ([]LSA, error) {
var i uint32 = 0
var offset uint32 = 0
for ; i < num; i++ {
if int(offset+20) > len(data) {
return nil, fmt.Errorf("LSAv2 too short at offset %d for LSA header", offset)
}
lstype := uint16(data[offset+3])
lsalength := binary.BigEndian.Uint16(data[offset+18 : offset+20])
content, err := extractLSAInformation(lstype, lsalength, data[offset:])
Expand Down Expand Up @@ -454,6 +457,9 @@ func getLSAs(num uint32, data []byte) ([]LSA, error) {
var i uint32 = 0
var offset uint32 = 0
for ; i < num; i++ {
if int(offset+20) > len(data) {
return nil, fmt.Errorf("LSA too short at offset %d for LSA header", offset)
}
var content interface{}
lstype := binary.BigEndian.Uint16(data[offset+2 : offset+4])
lsalength := binary.BigEndian.Uint16(data[offset+18 : offset+20])
Expand Down Expand Up @@ -495,6 +501,10 @@ func (ospf *OSPFv2) DecodeFromBytes(data []byte, df gopacket.DecodeFeedback) err
ospf.AuType = binary.BigEndian.Uint16(data[14:16])
ospf.Authentication = binary.BigEndian.Uint64(data[16:24])

if int(ospf.PacketLength) > len(data) {
return fmt.Errorf("OSPF packet length %d exceeds data length %d", ospf.PacketLength, len(data))
}

switch ospf.Type {
case OSPFHello:
var neighbors []uint32
Expand Down Expand Up @@ -592,6 +602,10 @@ func (ospf *OSPFv3) DecodeFromBytes(data []byte, df gopacket.DecodeFeedback) err
ospf.Instance = uint8(data[14])
ospf.Reserved = uint8(data[15])

if int(ospf.PacketLength) > len(data) {
return fmt.Errorf("OSPF packet length %d exceeds data length %d", ospf.PacketLength, len(data))
}

switch ospf.Type {
case OSPFHello:
var neighbors []uint32
Expand Down