Document Android local build prerequisites and smoke test#963
Open
archit-goyal wants to merge 1 commit into
Open
Document Android local build prerequisites and smoke test#963archit-goyal wants to merge 1 commit into
archit-goyal wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
e0c0c5a to
f72b189
Compare
Author
|
Hi maintainers, just gently following up on this PR. Please let me know if there is anything I should adjust or any extra verification that would help. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Android/src../gradlew :app:assembleDebugbuild check before Hugging Face OAuth setup.Android/README.mdto the development instructions.Why
I tried a fresh-clone setup pass and found the Android build docs assumed local Android/JDK setup and Hugging Face OAuth context before giving contributors a basic build check. This makes the setup boundary explicit and gives contributors a smaller first command to verify the project syncs and compiles.
Verification
git diff --check../gradlew :app:assembleDebugfrom a fresh clone; local verification is blocked on this machine because Java/Android Studio/Android SDK are not installed.