Skip to content

Fix download failure notification body text#827

Open
salmanmkc wants to merge 363 commits into
google-ai-edge:mainfrom
salmanmkc:salmanmkc/fix-failed-download-notification
Open

Fix download failure notification body text#827
salmanmkc wants to merge 363 commits into
google-ai-edge:mainfrom
salmanmkc:salmanmkc/fix-failed-download-notification

Conversation

@salmanmkc

@salmanmkc salmanmkc commented May 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Fixes #704.

When a model download fails, the notification has a failure title ("Model download failed") but the body uses notification_content_success ("Model %s has been downloaded") so users get told the model finished downloading when it actually failed. Swap the body string to notification_content_fail which already exists and uses the same %s placeholder.

Test plan

  • ./gradlew :app:compileDebugKotlin passes locally.
  • The reporter already pinpointed the line; behavioural test on a real device needs a forced download failure, which is hard to reproduce reliably in an emulator.

jinjingforever and others added 30 commits August 20, 2025 16:03
@jinjingforever
Add 1.0.5 allowlist
adb2eb8
@copybara-github
Securely store the access token in an encrypted proto data store
e5336db 
PiperOrigin-RevId: 797861660
@jinjingforever
Add allowlist for 1.0.6
6c408b7
@copybara-github
internal cleanup
f38790c 
PiperOrigin-RevId: 798305739
@copybara-github
Update user data serializer
c463086 
PiperOrigin-RevId: 798306012
@copybara-github
Update terms per legal's request, and bump the version number.
57747df 
PiperOrigin-RevId: 798368240
Fix typo in description of Gemma-3n-E2B-it in model allowlists.
f391448
@dpknag
Merge pull request google-ai-edge#253 from google-ai-edge/dpknag-patch-2
1b87419 
Add Android OS requirement to README
@copybara-github
Internal cleanup
b6c7fb0 
PiperOrigin-RevId: 799245337
@copybara-github
Exposes supportImage and supportAudio as parameter
819c5cc 
PiperOrigin-RevId: 799283470
@jinjingforever
Update README.md
e972784
@copybara-github
Exposes supportImage and supportAudio as parameter in resetSession.
f17fcb9 
PiperOrigin-RevId: 799311930
@copybara-github
Add new e2e test for Gemma1B in Prompt Lab
093c473 
PiperOrigin-RevId: 800107395
@copybara-github
Internal cleanup
e07d3ec 
PiperOrigin-RevId: 800516780
@copybara-github
Add new e2e test for Gemma2B in Ask Image
82a087d 
PiperOrigin-RevId: 800638495
@copybara-github
Fix NPE crash due to failure to download.
6623d54 
PiperOrigin-RevId: 802190892
@copybara-github
Remove object instead of index to avoid potential crash.
a9e96d8 
PiperOrigin-RevId: 802213068
@copybara-github
Remove extra space below text input when IME is visible
9c7385b 
PiperOrigin-RevId: 802314131
@copybara-github
Update splash screen with animated icon. Also make the "failed to loa…
6383704 
…d allowlist" dialog dismissable.

PiperOrigin-RevId: 803496612
@whhone @copybara-github
[gallery] fix a crash on user providing invalid text value for a number
5c55998 
PiperOrigin-RevId: 804957426
@copybara-github
Add animation for audio recording and simplify audio recording ui.
8fe1237 
PiperOrigin-RevId: 805034733
@copybara-github
Internal cleanup
25b8dad 
PiperOrigin-RevId: 805432594
@jinjingforever
Add allowlist for 1.0.7
ce6b21a
@copybara-github
Add e2e test for Gemma3n2b in Ask Image: T2 case Multi-turn follow-up
fce2b4a 
PiperOrigin-RevId: 805870399
@copybara-github
Improvements:
b083278 
- Hide keyboard after sending a prompt.
- Scroll to bottom when a new prompt is sent.
- Show warning when user tries to import a web model.

PiperOrigin-RevId: 805909987
@whhone @copybara-github
[gallery] allow download model using a git reference
e5f2d93 
PiperOrigin-RevId: 807750198
@copybara-github
New loader animation and refactor of scrollng handling for chat view
b547c01 
PiperOrigin-RevId: 807762995
@jinjingforever
Merge pull request google-ai-edge#261 from EsmaeelNabil/fixes-typo
28a4612 
Fixes a typo
@jinjingforever
Update 1_0_7.json
ab300d0
@copybara-github
Moro auto-scrolling related fix.
ea85652 
PiperOrigin-RevId: 807856963
yishuangP and others added 29 commits May 5, 2026 13:15
@yishuangP @copybara-github
Add speculative decoding configuration option in Gallery.
11ec84e 
PiperOrigin-RevId: 906649917
@copybara-github
Truncate remote_url parameter to 100 characters.
a33d7c1 
PiperOrigin-RevId: 906753938
@zichuan-wei @copybara-github
internal change
bdf365f 
PiperOrigin-RevId: 907029492
@copybara-github
Fix Firebase Analytics truncation for active skills list in Android b…
eea36f7 
…y using deterministic short IDs.

PiperOrigin-RevId: 907072316
@zichuan-wei @copybara-github
internal change
327ad51 
PiperOrigin-RevId: 907086171
@copybara-github
Add skill_id to skill_execution event for iOS and Android.
bb17c08 
PiperOrigin-RevId: 907092493
@copybara-github
Internal changes
59c9893 
PiperOrigin-RevId: 907174331
@copybara-github
Enable support for execution on Pixel TPU
66377ed 
PiperOrigin-RevId: 907388189
@hheydary @copybara-github
Initialize engine with correct speculative decoding flag.
b5f5993 
PiperOrigin-RevId: 907668212
@copybara-github
Extract some reusable composables.
82b18e0 
PiperOrigin-RevId: 908801411
@zichuan-wei @copybara-github
internal change
88ec026 
PiperOrigin-RevId: 910146658
@yijie-yang @copybara-github
Core System Prompt Storage & Retrieval
94b7189 
- Added `SystemPromptRepository` to persist custom prompts via DataStore.
- Added `SystemPromptHelper` to resolve the effective prompt (custom override vs. default fallback)

PiperOrigin-RevId: 910346906
@yijie-yang @copybara-github
Add dynamic system instructions to CustomTask initialization
0fb304d 
PiperOrigin-RevId: 910957874
@yijie-yang @copybara-github
UI Integration for System Prompt Editing
91e1b54 
PiperOrigin-RevId: 910995322
@yishuangP @copybara-github
Update litertlm dependency to version 0.11.0.
0079396 
PiperOrigin-RevId: 911586327
@yishuangP @copybara-github
Set speculative decoding based on setting and model file ...
115d355 
PiperOrigin-RevId: 911598177
@zichuan-wei @copybara-github
Add chat history saving for text only.
2e28f48 
PiperOrigin-RevId: 911749453
@jinjingforever
Merge pull request google-ai-edge#629 from kuishou68/fix-readme-funct…
4e94d4b 
…iongemma-typo

fix: correct FunctionGemma typo in README
@copybara-github
Update the UI for both the Chat and Prompt Lab to better match the Ge…
d372dfd 
…mini app experience.

Key Changes:
- **Smoother Token Streaming**: Replaced the token-by-token display with a fade-in effect that reveals buffered chunks of tokens during model response streaming.
- **Updated Scrolling Behavior**: Disabled auto-scrolling. Introduced a "Jump to bottom" button that appears whenever the content area is scrollable.
- **Cleaner Model Response**: Remove the "bubble" around the model response text and make text full width.
- **Optimized Screen Space (Chat Only)**: When a new user prompt is sent, the view now automatically scrolls to align the prompt with the top edge of the screen, maximizing the visible area for the incoming response.

PiperOrigin-RevId: 912129993
@yishuangP @copybara-github
Add create-calendar-event skill. Add "create_calendar_event" and "get…
ad7aad8 
…_current_date_and_time" intents.

PiperOrigin-RevId: 912136923
@copybara-github
Enable sideloaded model execution support on Pixel TPU
cdaa184 
PiperOrigin-RevId: 912278828
@copybara-github
Add Firebase Analytics logging for chat history on Android.
3884a5c 
PiperOrigin-RevId: 912570504
@zichuan-wei @copybara-github
update the load history logic
51a7a13 
PiperOrigin-RevId: 913067368
@zichuan-wei @copybara-github
Add support for image and audio messages in chat history.
dd18ea4 
PiperOrigin-RevId: 913170264
@zichuan-wei @copybara-github
fix UI render regression
11cbf27 
PiperOrigin-RevId: 913755747
@yishuangP @copybara-github
Add support for scheduling one-time or daily notifications in Agent C…
84ca2f3 
…hat. Introduces a new `schedule_notification` action in IntentHandler.

PiperOrigin-RevId: 913782888
@yishuangP @copybara-github
Add a Notifications Management Screen for managing the scheduled noti…
9067856 
…fications in Agent Chat.

PiperOrigin-RevId: 913888328
@yishuangP @copybara-github
Enable deeplink support for LLM Agent Chat. This change allows notifi…
8ab46ea 
…cations scheduled via the "schedule-notification" skill to open the LLM Agent Chat screen with a pre-filled query.

PiperOrigin-RevId: 913949881
@salmanmkc
Fix failed download notification using success body text
3e166d9 
The failure branch in DownloadRepository was formatting the notification
body with notification_content_success ("Model X has been downloaded")
while showing the failure title, so users got a contradictory message
saying the model finished downloading when it actually failed. Use
notification_content_fail instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]