ghoul: resource-leak - close gzip.Reader after decompressing descriptors - #1717
Open
fereidani wants to merge 1 commit into
Open
ghoul: resource-leak - close gzip.Reader after decompressing descriptors#1717fereidani wants to merge 1 commit into
fereidani wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I have built a static analyzer for Go called Ghoul, and I ran it against the protobuf codebase. It flagged two resource leaks where a gzip.Reader used to decompress registered file descriptors is allocated but never closed.
Ghoul related reports:
This change adds
defer zr.Close()right after the error check inproto.RegisterFileanddescriptor.deriveFileDescriptor, so the reader is released once the descriptor bytes have been read. The decompression logic and its error handling are unchanged; the patch only adds the close.