Skip to content

Fix zip corruption in pre command output #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajaynes-godaddy merged 1 commit into from
Jun 10, 2026
Merged

Fix zip corruption in pre command output #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tasks/copy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,12 @@ const copyPrereleaseTask = (done) => {

const filter = gulpFilter([`**/${filename}.txt`], { restore: true })

// encoding: false is required so the zip isn't corrupted by utf-8 round-tripping
// @link https://github.com/gulpjs/gulp/issues/2790
return gulp.src([
`${sake.config.paths.build}/${sake.config.plugin.id}*.zip`,
`${sake.config.paths.build}/${sake.config.plugin.id}/${filename}.txt`
]).pipe(filter)
], { encoding: false }).pipe(filter)
.pipe(rename({ prefix: sake.config.plugin.id + '_' }))
.pipe(filter.restore)
.pipe(gulp.dest(sake.getPrereleasesPath()))
Expand Down