Skip to content

Remove option dbg.dump#2054

Open
sim642 wants to merge 4 commits into
masterfrom
rm-dbg.dump
Open

Remove option dbg.dump#2054
sim642 wants to merge 4 commits into
masterfrom
rm-dbg.dump

Conversation

@sim642

@sim642 sim642 commented Jun 9, 2026

Copy link
Copy Markdown
Member

It's described as "Dumps the results to the given path" and it is some kind of strange override for outfile ("File to print output to.").

Copilot AI review requested due to automatic review settings June 9, 2026 12:28
@sim642 sim642 added the cleanup Refactoring, clean-up label Jun 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the dbg.dump option (a special-case output redirection mechanism) and simplifies result/log output routing to use the normal outfile/standard channels instead.

Changes:

  • Removed dbg.dump handling from CLI initialization (maingoblint.ml), including its special override behavior.
  • Removed dbg.dump from the JSON options schema and eliminated Messages.get_out (which depended on dbg.dump).
  • Updated result/log output code paths to write directly to the configured output channels (!Messages.out, stderr, etc.) without per-component dump files.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/maingoblint.ml Removes runtime handling for dbg.dump and simplifies CIL/timing output channel selection.
src/framework/xsltResultOutput.ml Removes dbg.dump-based output indirection; writes XSLT output to !Messages.out.
src/framework/control.ml Removes get_out usage and prints globals directly to !M.out.
src/framework/analysisResultOutput.ml Removes get_out usage; outputs results to !Messages.out.
src/config/options.schema.json Removes the dbg.dump option from the schema.
src/common/util/messages.ml Deletes Messages.get_out, which implemented dbg.dump-based per-file output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings June 9, 2026 12:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Refactoring, clean-up

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants