Remove option dbg.dump#2054
Open
sim642 wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the dbg.dump option (a special-case output redirection mechanism) and simplifies result/log output routing to use the normal outfile/standard channels instead.
Changes:
- Removed
dbg.dumphandling from CLI initialization (maingoblint.ml), including its special override behavior. - Removed
dbg.dumpfrom the JSON options schema and eliminatedMessages.get_out(which depended ondbg.dump). - Updated result/log output code paths to write directly to the configured output channels (
!Messages.out, stderr, etc.) without per-component dump files.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/maingoblint.ml | Removes runtime handling for dbg.dump and simplifies CIL/timing output channel selection. |
| src/framework/xsltResultOutput.ml | Removes dbg.dump-based output indirection; writes XSLT output to !Messages.out. |
| src/framework/control.ml | Removes get_out usage and prints globals directly to !M.out. |
| src/framework/analysisResultOutput.ml | Removes get_out usage; outputs results to !Messages.out. |
| src/config/options.schema.json | Removes the dbg.dump option from the schema. |
| src/common/util/messages.ml | Deletes Messages.get_out, which implemented dbg.dump-based per-file output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's described as "Dumps the results to the given path" and it is some kind of strange override for
outfile("File to print output to.").