Open
Conversation
Original issue
---
You can't use type with custom GetBSON() method mixed with structure field type and structure field reference type.
For example, you can't create custom GetBSON() for Bar type:
```
struct Foo {
a Bar
b *Bar
}
```
Type implementation (`func (t Bar) GetBSON()` ) would crash on `Foo.b = nil` value encoding.
Reference implementation (`func (t *Bar) GetBSON()` ) would not call on `Foo.a` value encoding.
After this change
---
For type implementation `func (t Bar) GetBSON()` would not call on `Foo.b = nil` value encoding.
In this case `nil` value would be seariazied as `nil` BSON value.
For reference implementation `func (t *Bar) GetBSON()` would call even on `Foo.a` value encoding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original issue
You can't use type with custom GetBSON() method mixed with structure field type and structure field reference type.
For example, you can't create custom GetBSON() for Bar type:
Type implementation (
func (t Bar) GetBSON()) would crash onFoo.b = nilvalue encoding.Reference implementation (
func (t *Bar) GetBSON()) would not call onFoo.avalue encoding.After this change
For type implementation
func (t Bar) GetBSON()would not call onFoo.b = nilvalue encoding.In this case
nilvalue would be seariazied asnilBSON value.For reference implementation
func (t *Bar) GetBSON()would call even onFoo.avalue encoding.