make stop-local-server fails with Docker due to unsupported -t option#584
Merged
Conversation
…mmand does not have it
cpuschma
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
make stop-local-serverfails when using Docker as the container runtime. TheMakefilecurrently callsdocker rm -f -t 10, but the-t(--time) flag is not supported bydocker rm.The
-t/--timeflag specifies a stop timeout and exists inpodman rm, but it is not available indocker rm.Since this is a development server, would a graceful shutdown timeout still be necessary? If not, removing the
-t 10option would make the command compatible with both Docker and Podman.