Skip to content

make stop-local-server fails with Docker due to unsupported -t option#584

Merged
cpuschma merged 1 commit into
go-ldap:masterfrom
t2y:fix-makefile
Mar 26, 2026
Merged

make stop-local-server fails with Docker due to unsupported -t option#584
cpuschma merged 1 commit into
go-ldap:masterfrom
t2y:fix-makefile

Conversation

@t2y
Copy link
Copy Markdown
Contributor

@t2y t2y commented Mar 26, 2026

Running make stop-local-server fails when using Docker as the container runtime. The Makefile currently calls docker rm -f -t 10, but the -t (--time) flag is not supported by docker rm.

$ make stop-local-server 
/usr/bin/docker rm -f -t 10 go-ldap-test
unknown shorthand flag: 't' in -t

Usage:  docker rm [OPTIONS] CONTAINER [CONTAINER...]

Run 'docker rm --help' for more information
make: [Makefile:50: stop-local-server] Error 125 (ignored)

The -t / --time flag specifies a stop timeout and exists in podman rm, but it is not available in docker rm.

Since this is a development server, would a graceful shutdown timeout still be necessary? If not, removing the -t 10 option would make the command compatible with both Docker and Podman.

@cpuschma cpuschma merged commit 1fd1503 into go-ldap:master Mar 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants